Discussion:
[Numpy-discussion] PR #7090: ENH: Added 'doane' and 'sqrt' estimators to np.histogram
Joseph Fox-Rabinovitz
2016-01-24 03:30:03 UTC
Permalink
As someone very new to relatively large projects such as numpy, I was
wondering how the process works. I have announced my PR with some
small enhancements to the histogram function and fixed up all of the
comments that were made (originally to PR 7083). What happens next?
All I have to go on is
http://docs.scipy.org/doc/numpy-1.10.1/dev/gitwash/development_workflow.html#asking-for-your-changes-to-be-merged-with-the-main-repo,
but that does not go into detail about what happens after the point I
have already reached.

Regards,

-Joe


On Thu, Jan 21, 2016 at 3:37 PM, Joseph Fox-Rabinovitz
Due to a mistake I made in my branch structure, I have replaced this
PR with #7090: https://github.com/numpy/numpy/pull/7090. All of the
changes and fixes so far are squashed into the new request.
-Joe
On Thu, Jan 21, 2016 at 1:51 AM, Joseph Fox-Rabinovitz
Please let me know if there is anything wrong or missing. I have added
a couple of estimators that I find useful sometimes.
-Joe
Charles R Harris
2016-01-24 16:36:00 UTC
Permalink
On Sat, Jan 23, 2016 at 8:30 PM, Joseph Fox-Rabinovitz <
Post by Joseph Fox-Rabinovitz
As someone very new to relatively large projects such as numpy, I was
wondering how the process works. I have announced my PR with some
small enhancements to the histogram function and fixed up all of the
comments that were made (originally to PR 7083). What happens next?
All I have to go on is
http://docs.scipy.org/doc/numpy-1.10.1/dev/gitwash/development_workflow.html#asking-for-your-changes-to-be-merged-with-the-main-repo
,
but that does not go into detail about what happens after the point I
have already reached.
Basically, wait. Maybe squeak now and then. It's frustrating, but we have
difficulty keeping up with the flow of pull requests.

Chuck
Joseph Fox-Rabinovitz
2016-01-24 22:08:54 UTC
Permalink
Sounds good. Waiting is not really frustrating as long as I know that
that is what I am doing. I thought I was missing a step somewhere
along the way.

Regards,

-Joe


On Sun, Jan 24, 2016 at 11:36 AM, Charles R Harris
Post by Charles R Harris
On Sat, Jan 23, 2016 at 8:30 PM, Joseph Fox-Rabinovitz
Post by Joseph Fox-Rabinovitz
As someone very new to relatively large projects such as numpy, I was
wondering how the process works. I have announced my PR with some
small enhancements to the histogram function and fixed up all of the
comments that were made (originally to PR 7083). What happens next?
All I have to go on is
http://docs.scipy.org/doc/numpy-1.10.1/dev/gitwash/development_workflow.html#asking-for-your-changes-to-be-merged-with-the-main-repo,
but that does not go into detail about what happens after the point I
have already reached.
Basically, wait. Maybe squeak now and then. It's frustrating, but we have
difficulty keeping up with the flow of pull requests.
Chuck
_______________________________________________
NumPy-Discussion mailing list
https://mail.scipy.org/mailman/listinfo/numpy-discussion
Loading...