Honi Sanders
2016-05-03 15:43:18 UTC
Hello all,
I have completed a pull request to add a âmaxlagâ functionality to numpy.correlate. See here: https://github.com/numpy/numpy/pull/5978 <https://github.com/numpy/numpy/pull/5978>. This pull request has passed all tests and has been ready to be merged for around six months. Several people have commented requesting for it to be included on stackoverflow, the listserve, and github. Can someone please let me know what needs to be done or can it be merged?
Here is some background:
What was troubling me is that numpy.correlate does not have a maxlag feature. This means that even if I only want to see correlations between two time series with lags between -100 and +100 ms, for example, it will still calculate the correlation for every lag between -20000 and +20000 ms (which is the length of the time series). This (theoretically) gives a 200x performance hit!
I have introduced this question as a numpy issue <https://github.com/numpy/numpy/issues/5954>, a scipy issue <https://github.com/scipy/scipy/issues/4940> and on the scipy-dev list <http://mail.scipy.org/pipermail/scipy-dev/2015-June/020757.html>. It seems the best place to start is with numpy.correlate, so that is what I am requesting.
Previous discussion of this functionality can be found at another discussion on numpy correlate (and convolution) <http://numpy-discussion.10968.n7.nabble.com/another-discussion-on-numpy-correlate-and-convolution-td32925.html>. Other issues related to correlate functions include ENH: Fold fftconvolve into convolve/correlate functions as a parameter #2651 <https://github.com/scipy/scipy/issues/2651>, Use FFT in np.correlate/convolve? (Trac #1260) #1858 <https://github.com/numpy/numpy/issues/1858>, and normalized cross-correlation (Trac #1714) #2310 <https://github.com/numpy/numpy/issues/2310>.
The new implementation allows new types of the âmodeâ argument, to include an int value, which defines the maximum lag for which cross-correlation should be calculated, or a tuple, which defines the minlag, maxlag, and lagstep to be used in the same format as the arguments to numpy.arange.
Please let me know what should be done to move this pull request forward.
Honi
I have completed a pull request to add a âmaxlagâ functionality to numpy.correlate. See here: https://github.com/numpy/numpy/pull/5978 <https://github.com/numpy/numpy/pull/5978>. This pull request has passed all tests and has been ready to be merged for around six months. Several people have commented requesting for it to be included on stackoverflow, the listserve, and github. Can someone please let me know what needs to be done or can it be merged?
Here is some background:
What was troubling me is that numpy.correlate does not have a maxlag feature. This means that even if I only want to see correlations between two time series with lags between -100 and +100 ms, for example, it will still calculate the correlation for every lag between -20000 and +20000 ms (which is the length of the time series). This (theoretically) gives a 200x performance hit!
I have introduced this question as a numpy issue <https://github.com/numpy/numpy/issues/5954>, a scipy issue <https://github.com/scipy/scipy/issues/4940> and on the scipy-dev list <http://mail.scipy.org/pipermail/scipy-dev/2015-June/020757.html>. It seems the best place to start is with numpy.correlate, so that is what I am requesting.
Previous discussion of this functionality can be found at another discussion on numpy correlate (and convolution) <http://numpy-discussion.10968.n7.nabble.com/another-discussion-on-numpy-correlate-and-convolution-td32925.html>. Other issues related to correlate functions include ENH: Fold fftconvolve into convolve/correlate functions as a parameter #2651 <https://github.com/scipy/scipy/issues/2651>, Use FFT in np.correlate/convolve? (Trac #1260) #1858 <https://github.com/numpy/numpy/issues/1858>, and normalized cross-correlation (Trac #1714) #2310 <https://github.com/numpy/numpy/issues/2310>.
The new implementation allows new types of the âmodeâ argument, to include an int value, which defines the maximum lag for which cross-correlation should be calculated, or a tuple, which defines the minlag, maxlag, and lagstep to be used in the same format as the arguments to numpy.arange.
Please let me know what should be done to move this pull request forward.
Honi