Discussion:
[Numpy-discussion] unsubscribe
Paul Lucek
2016-07-06 14:25:06 UTC
Permalink
Send NumPy-Discussion mailing list submissions to
To subscribe or unsubscribe via the World Wide Web, visit
https://mail.scipy.org/mailman/listinfo/numpy-discussion
or, via email, send a message with subject or body 'help' to
You can reach the person managing the list at
When replying, please edit your Subject line so it is more specific
than "Re: Contents of NumPy-Discussion digest..."
1. Re: Added atleast_nd, request for clarification/cleanup of
atleast_3d (Joseph Fox-Rabinovitz)
2. Re: Added atleast_nd, request for clarification/cleanup of
atleast_3d (Benjamin Root)
3. Re: Added atleast_nd, request for clarification/cleanup of
atleast_3d (Marten van Kerkwijk)
----------------------------------------------------------------------
Message: 1
Date: Wed, 6 Jul 2016 09:12:32 -0400
<javascript:;>>
Subject: Re: [Numpy-discussion] Added atleast_nd, request for
clarification/cleanup of atleast_3d
<CAAa1KPa0RXYH3cCSyRGqpS_hzx9=K=
Content-Type: text/plain; charset=UTF-8
I can add a keyword-only argument that lets you put the new dims
before or after the existing ones. I am not sure how to specify
arbitrary patterns for the new dimensions, but that should take care
of most use cases.
The use case that motivated this function in the first place is that I
am doing some processing on 4D arrays and I need to reduce them but
return a result with the original dimensionality (but not shape).
atleast_nd seemed like a better solution than atleast_4d.
-Joe
<javascript:;>>
On Jul 5, 2016 9:09 PM, "Joseph Fox-Rabinovitz"
Hi,
I have generalized np.atleast_1d, np.atleast_2d, np.atleast_3d with
a
function np.atleast_nd in PR#7804
(https://github.com/numpy/numpy/pull/7804).
As a result of this PR, I have a couple of questions about
`np.atleast_3d`. `np.atleast_3d` appears to do something weird with
the dimensions: If the input is 1D, it prepends and appends a size-1
dimension. If the input is 2D, it appends a size-1 dimension. This
is
inconsistent with `np.atleast_2d`, which always prepends (as does
`np.atleast_nd`).
- Is there any reason for this behavior?
- Can it be cleaned up (e.g., by reimplementing `np.atleast_3d` in
terms of `np.atleast_nd`, which is actually much simpler)? This
would
be a slight API change since the output would not be exactly the
same.
Changing atleast_3d seems likely to break a bunch of stuff...
Beyond that, I find it hard to have an opinion about the best design
for
these functions, because I don't think I've ever encountered a
situation
where they were actually what I wanted. I'm not a big fan of coercing
dimensions in the first place, for the usual "refuse to guess"
reasons. And
then generally if I do want to coerce an array to another dimension,
then I
have some opinion about where the new dimensions should go, and/or I
have
some opinion about the minimum acceptable starting dimension, and/or
I have
a maximum dimension in mind. (E.g. "coerce 1d inputs into a column
matrix;
0d or 3d inputs are an error" -- atleast_2d is zero-for-three on that
requirements list.)
I don't know how typical I am in this. But it does make me wonder if
the
atleast_* functions act as an attractive nuisance, where new users
take
their presence as an implicit recommendation that they are actually a
useful
thing to reach for, even though they... aren't that. And maybe we
should be
recommending folk move away from them rather than trying to extend
them
further?
Or maybe they're totally useful and I'm just missing it. What's your
use
case that motivates atleast_nd?
I think you're just missing it:) atleast_1d/2d are used quite a bit in
Scipy and Statsmodels (those are the only ones I checked), and in the
large
majority of cases it's the best thing to use there. There's a bunch of
atleast_2d calls with a transpose appended because the input needs to
be
treated as columns instead of rows, but that's still efficient and
readable
enough.
As Ralph pointed out its usage in statsmodels. I do find them useful as
replacement for several lines of ifs and reshapes
We stilll need in many cases the atleast_2d_cols, that appends the
newaxis
if necessary.
roughly the equivalent of
x = x[:, None]
x = np.atleast_2d(x)
Josef
For 3D/nD I can see that you'd need more control over where the
dimensions go, but 1D/2D are fine.
statsmodels has currently very little code with ndim >2, so I have no
overview of possible use cases, but it would be necessary to have full
control over the added axis since axis have a strict meaning and stats
still
prefer Fortran order to default numpy/C ordering.
Josef
Ralf
_______________________________________________
NumPy-Discussion mailing list
https://mail.scipy.org/mailman/listinfo/numpy-discussion
_______________________________________________
NumPy-Discussion mailing list
https://mail.scipy.org/mailman/listinfo/numpy-discussion
------------------------------
Message: 2
Date: Wed, 6 Jul 2016 09:51:16 -0400
<javascript:;>>
Subject: Re: [Numpy-discussion] Added atleast_nd, request for
clarification/cleanup of atleast_3d
<
<javascript:;>>
Content-Type: text/plain; charset="utf-8"
While atleast_1d/2d/3d predates my involvement in numpy, I am probably
partly to blame for popularizing them as I helped to fix them up a fair
amount. I wouldn't call its use "guessing". Rather, I would treat them as
useful input sanitizers. If your function is going to be doing 2d indexing
on an input, then it is very convenient to have atleast_2d() at the top of
your function, not only to sanitize the input, but to make it clear that
your code expects at least two dimensions.
One place where it is used is in np.loadtxt(..., ndmin=N) to protect
against the situation of a single row of data becoming a 1-D array rather
than a 2-D array (or an empty text file returning something completely
useless).
I have previously pointed out the oddity with atleast_3d(). I can't
remember the explanation I got though. Maybe someone can find the old
thread that has the explanation, if any?
I think the keyword argument approach for controlling the behavior might be
a good approach, provided that a suitable design could be devised. 1 & 2
dimensions is fairly trivial to control, but 3+ dimensions has too many
degrees of freedom for me to consider.
Cheers!
Ben Root
On Wed, Jul 6, 2016 at 9:12 AM, Joseph Fox-Rabinovitz <
I can add a keyword-only argument that lets you put the new dims
before or after the existing ones. I am not sure how to specify
arbitrary patterns for the new dimensions, but that should take care
of most use cases.
The use case that motivated this function in the first place is that I
am doing some processing on 4D arrays and I need to reduce them but
return a result with the original dimensionality (but not shape).
atleast_nd seemed like a better solution than atleast_4d.
-Joe
<javascript:;>>
On Jul 5, 2016 9:09 PM, "Joseph Fox-Rabinovitz"
Hi,
I have generalized np.atleast_1d, np.atleast_2d, np.atleast_3d
with
a
function np.atleast_nd in PR#7804
(https://github.com/numpy/numpy/pull/7804).
As a result of this PR, I have a couple of questions about
`np.atleast_3d`. `np.atleast_3d` appears to do something weird
with
the dimensions: If the input is 1D, it prepends and appends a
size-1
dimension. If the input is 2D, it appends a size-1 dimension. This
is
inconsistent with `np.atleast_2d`, which always prepends (as does
`np.atleast_nd`).
- Is there any reason for this behavior?
- Can it be cleaned up (e.g., by reimplementing `np.atleast_3d`
in
terms of `np.atleast_nd`, which is actually much simpler)? This
would
be a slight API change since the output would not be exactly the
same.
Changing atleast_3d seems likely to break a bunch of stuff...
Beyond that, I find it hard to have an opinion about the best design
for
these functions, because I don't think I've ever encountered a
situation
where they were actually what I wanted. I'm not a big fan of
coercing
dimensions in the first place, for the usual "refuse to guess"
reasons. And
then generally if I do want to coerce an array to another dimension,
then I
have some opinion about where the new dimensions should go, and/or I
have
some opinion about the minimum acceptable starting dimension, and/or
I have
a maximum dimension in mind. (E.g. "coerce 1d inputs into a column
matrix;
0d or 3d inputs are an error" -- atleast_2d is zero-for-three on
that
requirements list.)
I don't know how typical I am in this. But it does make me wonder if
the
atleast_* functions act as an attractive nuisance, where new users
take
their presence as an implicit recommendation that they are actually
a
useful
thing to reach for, even though they... aren't that. And maybe we
should be
recommending folk move away from them rather than trying to extend
them
further?
Or maybe they're totally useful and I'm just missing it. What's your
use
case that motivates atleast_nd?
I think you're just missing it:) atleast_1d/2d are used quite a bit
in
Scipy and Statsmodels (those are the only ones I checked), and in the
large
majority of cases it's the best thing to use there. There's a bunch
of
atleast_2d calls with a transpose appended because the input needs to
be
treated as columns instead of rows, but that's still efficient and
readable
enough.
As Ralph pointed out its usage in statsmodels. I do find them useful
as
replacement for several lines of ifs and reshapes
We stilll need in many cases the atleast_2d_cols, that appends the
newaxis
if necessary.
roughly the equivalent of
x = x[:, None]
x = np.atleast_2d(x)
Josef
For 3D/nD I can see that you'd need more control over where the
dimensions go, but 1D/2D are fine.
statsmodels has currently very little code with ndim >2, so I have no
overview of possible use cases, but it would be necessary to have full
control over the added axis since axis have a strict meaning and stats
still
prefer Fortran order to default numpy/C ordering.
Josef
Ralf
_______________________________________________
NumPy-Discussion mailing list
https://mail.scipy.org/mailman/listinfo/numpy-discussion
_______________________________________________
NumPy-Discussion mailing list
https://mail.scipy.org/mailman/listinfo/numpy-discussion
_______________________________________________
NumPy-Discussion mailing list
https://mail.scipy.org/mailman/listinfo/numpy-discussion
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <
https://mail.scipy.org/pipermail/numpy-discussion/attachments/20160706/4241522b/attachment-0001.html
------------------------------
Message: 3
Date: Wed, 6 Jul 2016 10:22:05 -0400
<javascript:;>>
Subject: Re: [Numpy-discussion] Added atleast_nd, request for
clarification/cleanup of atleast_3d
<
<javascript:;>>
Content-Type: text/plain; charset="utf-8"
Hi All,
I'm with Nathaniel here, in that I don't really see the point of these
routines in the first place: broadcasting takes care of many of the initial
use cases one might think of, and others are generally not all that well
served by them: the examples from scipy to me do not really support
`at_least?d`, but rather suggest that little thought has been put into
higher-dimensional objects which should be treated as stacks of row or
column vectors. My sense is that we're better off developing the direction
started with `matmul`, perhaps adding `matvecmul` etc.
More to the point of the initial inquiry: what is the advantage of having a
general `np.at_leastnd` routine over doing
```
np.array(a, copy=False, ndim=n)
```
or, for a list of inputs,
```
[np.array(a, copy=False, ndim=n) for a in input_list]
```
All the best,
Marten
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <
https://mail.scipy.org/pipermail/numpy-discussion/attachments/20160706/75f87f2d/attachment.html
------------------------------
Subject: Digest Footer
_______________________________________________
NumPy-Discussion mailing list
https://mail.scipy.org/mailman/listinfo/numpy-discussion
------------------------------
End of NumPy-Discussion Digest, Vol 118, Issue 9
************************************************
Loading...